Skip to content

DO NOT REVIEW Stress test x509 test #48332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

DO NOT REVIEW Stress test x509 test #48332

wants to merge 13 commits into from

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented May 19, 2023

Scratch PR to run something through CI a bunch of times.

@ghost ghost added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label May 19, 2023
@amcasey amcasey mentioned this pull request May 19, 2023
Merged
4 tasks
@amcasey
Copy link
Member Author

amcasey commented May 19, 2023

The failures have the error code I added, so they definitely indicate trimming issues and not (e.g.) crashes.

@amcasey
Copy link
Member Author

amcasey commented May 19, 2023

On the bright side, for each run, the tests either all passed or all failed.

@amcasey
Copy link
Member Author

amcasey commented May 19, 2023

I don't know why the windows test run doesn't show failure, but it had 10 errors (i.e. the test failed there too).

@amcasey
Copy link
Member Author

amcasey commented May 19, 2023

I wonder if the trimmer is seeing this call and keeping the type

GetType("System.Security.Cryptography", "System.Security.Cryptography.X509Certificates.X509Certificate")

(Note that this is my own GetType and not one from reflection)

@mkArtakMSFT mkArtakMSFT added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels May 22, 2023
@ghost
Copy link

ghost commented May 22, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@amcasey amcasey closed this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 Awaiting requested review from halter73 halter73 will be requested when the pull request is marked ready for review halter73 is a code owner

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe will be requested when the pull request is marked ready for review wtgodbe is a code owner

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amcasey @mkArtakMSFT